Dan Kenigsberg has submitted this change and it was merged. Change subject: Make sr-iov hook use interface instead of hostdev ......................................................................
Make sr-iov hook use interface instead of hostdev According to libvirt documentation, for the sr-iov virtual function "nics" to have permanent and unique MAC addresses, the passthrough should be done using <interface type='hostdev'> instead of <hostdev>. This change modifies the hook to take advantage of this libvirt definition for stable sr-iovs. The chown step is necessary to attach the virtual function to the VM Otherwise, it is not possible to detach the virtual function from the OS and attach it to the VM due to dynamic_ownership=0 (which is necessary for network storage because dynamic ownership, ATM, always sets ownership to root:root on VM destroy/hotunplug). Change-Id: Ib2f88a8400fe4d230c0877428afef62df8e397db Signed-off-by: Antoni S. Puimedon <[email protected]> --- M vdsm_hooks/sriov/after_vm_destroy.py M vdsm_hooks/sriov/before_vm_start.py 2 files changed, 34 insertions(+), 59 deletions(-) Approvals: Antoni Segura Puimedon: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13541 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2f88a8400fe4d230c0877428afef62df8e397db Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dan Yasny <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
