Ayal Baron has posted comments on this change.
Change subject: vdsm: Add after_vdsm_start hook
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File vdsm/hooks.py
Line 221: return _runHooksDir(None, 'before_vdsm_start', raiseError=False)
Line 222:
Line 223:
Line 224: def after_vdsm_start():
Line 225: return _runHooksDir(None, 'after_vdsm_start', raiseError=False)
why raiseError=False?
Line 226:
Line 227:
Line 228: def after_vdsm_stop():
Line 229: return _runHooksDir(None, 'after_vdsm_stop', raiseError=False)
....................................................
File vdsm/vdsmd.init.in
Line 511: RETVAL=$?
Line 512: [ "$RETVAL" -eq 0 ] && log_success_msg $"$prog start" ||
log_failure_msg $"$prog start"
Line 513: [ "$RETVAL" -eq 0 ] && touch /var/lock/subsys/vdsmd
Line 514:
Line 515: python @VDSMDIR@/hooks.pyc after_vdsm_start
Placing the hook here means that vdsm has started but not necessarily that
initialization has finished successfully.
I wonder if this shouldn't be at the end of clientIF.py: __init__
Line 516: }
Line 517:
Line 518: stop() {
Line 519: echo $"Shutting down vdsm daemon: "
--
To view, visit http://gerrit.ovirt.org/13543
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id02b2b7d091ffa0be57a3850fa97cdcd35778466
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
