Vered Volansky has posted comments on this change. Change subject: vdsm: Add after_vdsm_start hook ......................................................................
Patch Set 1: (1 inline comment) This patch necessity is currently in deliberations. I will not submit any other patchsets until this issue is resolved. .................................................... File vdsm/hooks.py Line 221: return _runHooksDir(None, 'before_vdsm_start', raiseError=False) Line 222: Line 223: Line 224: def after_vdsm_start(): Line 225: return _runHooksDir(None, 'after_vdsm_start', raiseError=False) If it were before the start then yes, since it's supposed to be after the start, the service have started anyway, true here would have failed the rest of the flow, which is unnecessary. Line 226: Line 227: Line 228: def after_vdsm_stop(): Line 229: return _runHooksDir(None, 'after_vdsm_stop', raiseError=False) -- To view, visit http://gerrit.ovirt.org/13543 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id02b2b7d091ffa0be57a3850fa97cdcd35778466 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
