Yaniv Bronhaim has uploaded a new change for review.

Change subject: Adding comment before getting libvirt connection
......................................................................

Adding comment before getting libvirt connection

If libvirt-sock does not exist, and vdsm is restarted - vdsm tried 10
seconds to communicate with libvirt. In the log we see a gap for 10
seconds after the "I am .." print and before the libvirt error exception.
This delay, without knowing the specific location of vdsm process, can hide
the actual reason for the delay. If the service stopped before the
exception we'll see only the "I am.. " print without knowing where vdsm
got stuck.

Change-Id: I8b6d8c53826fbb82f07a59f15edf672e855ef75f
Signed-off-by: Yaniv Bronhaim <[email protected]>
---
M lib/vdsm/libvirtconnection.py
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/86/13786/1

diff --git a/lib/vdsm/libvirtconnection.py b/lib/vdsm/libvirtconnection.py
index 4a9a09a..6213b40 100644
--- a/lib/vdsm/libvirtconnection.py
+++ b/lib/vdsm/libvirtconnection.py
@@ -20,6 +20,7 @@
 
 import threading
 import functools
+import logging
 
 import libvirt
 from vdsm import constants, utils
@@ -148,6 +149,7 @@
         if not conn:
             libvirtOpenAuth = functools.partial(libvirt.openAuth,
                                                 'qemu:///system', auth, 0)
+            logging.debug('trying to connect libvirt')
             conn = utils.retry(libvirtOpenAuth, timeout=10, sleep=0.2)
             __connections[id(cif)] = conn
             if cif is not None:


--
To view, visit http://gerrit.ovirt.org/13786
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8b6d8c53826fbb82f07a59f15edf672e855ef75f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to