Douglas Schilling Landgraf has posted comments on this change.
Change subject: Adding comment before getting libvirt connection
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File lib/vdsm/libvirtconnection.py
Line 148: conn = __connections.get(id(cif))
Line 149: if not conn:
Line 150: libvirtOpenAuth = functools.partial(libvirt.openAuth,
Line 151: 'qemu:///system',
auth, 0)
Line 152: logging.debug('trying to connect libvirt')
what about "trying to connect to libvirt auth [%s]" % auth ? or similar to that?
Line 153: conn = utils.retry(libvirtOpenAuth, timeout=10, sleep=0.2)
Line 154: __connections[id(cif)] = conn
Line 155: if cif is not None:
Line 156: for ev in (libvirt.VIR_DOMAIN_EVENT_ID_LIFECYCLE,
--
To view, visit http://gerrit.ovirt.org/13786
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b6d8c53826fbb82f07a59f15edf672e855ef75f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
