Assaf Muller has uploaded a new change for review. Change subject: Allow modification of disk xml by before_disk_hotplug ......................................................................
Allow modification of disk xml by before_disk_hotplug The return value of hooks.before_disk_hotplug wasn't being used like it is in hooks.before_nic_hotplug. Meaning that if a hook changed the disk XML it wasn't actually updated in the VM's domxml. Change-Id: I0b1cf81c696f68fbdb67a5a41a54f8f055c5b73b Signed-off-by: Assaf Muller <[email protected]> --- M vdsm/libvirtvm.py 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/03/13803/1 diff --git a/vdsm/libvirtvm.py b/vdsm/libvirtvm.py index 18ca5aa..f879ad4 100644 --- a/vdsm/libvirtvm.py +++ b/vdsm/libvirtvm.py @@ -1799,8 +1799,8 @@ driveXml = drive.getXML().toprettyxml(encoding='utf-8') self.log.debug("Hotplug disk xml: %s" % (driveXml)) - hooks.before_disk_hotplug(driveXml, self.conf, - params=params.get('custom', {})) + driveXml = hooks.before_disk_hotplug(driveXml, self.conf, + params=params.get('custom', {})) drive._deviceXML = driveXml try: self._dom.attachDevice(driveXml) -- To view, visit http://gerrit.ovirt.org/13803 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0b1cf81c696f68fbdb67a5a41a54f8f055c5b73b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
