Dan Kenigsberg has posted comments on this change.
Change subject: Allow modification of disk xml by before_disk_hotplug
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Yaniv, it seems that testIsSuperUp's calling panic() causes a lot of pains to
us all. At the very least, please monkey-patch it during unit tests.
TestSuperVdsm
testIsSuperUp Exception AttributeError: AttributeError("'_DummyThread' object
has no attribute '_Thread__block'",) in <module 'threading' from
'/usr/lib64/python2.7/threading.pyc'> ignored
FATAL: Unable to delete script file /tmp/hudson6955115821503368545.sh
....................................................
Commit Message
Line 5: CommitDate: 2013-04-11 11:51:38 +0300
Line 6:
Line 7: Allow modification of disk xml by before_disk_hotplug
Line 8:
Line 9: The return value of hooks.before_disk_hotplug wasn't being used
wasn't being --> hasn't been
Line 10: like it is in hooks.before_nic_hotplug. Meaning that if a hook
Line 11: changed the disk XML it wasn't actually updated in the VM's
Line 12: domxml.
Line 13:
--
To view, visit http://gerrit.ovirt.org/13803
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b1cf81c696f68fbdb67a5a41a54f8f055c5b73b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <[email protected]>
Gerrit-Reviewer: Assaf Muller <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
