Dan Kenigsberg has posted comments on this change. Change subject: Remove unnecessary storage log messages from logs ......................................................................
Patch Set 3: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/storage/blockSD.py Line 440: try: Line 441: rmanager.registerNamespace(lvmActivationNamespace, Line 442: lvmActivationFactory) Line 443: except KeyError: Line 444: pass frankly speaking, silently swallowing exceptions gives me the creeps, and with http://gerrit.ovirt.org/#/c/13692/ merged in, I am not at all sure that this is required here. would you agree to change the commit message, and only change Exception-->KeyError, without swallowing the traceback? Line 445: Line 446: @classmethod Line 447: def metaSize(cls, vgroup): Line 448: ''' Calc the minimal meta volume size in MB''' -- To view, visit http://gerrit.ovirt.org/13617 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifc0fa5ca50e4eb78d62fd3cdc8b09723486bcaa0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
