Dan Kenigsberg has submitted this change and it was merged. Change subject: Catch appropriate KeyError instead of any exception ......................................................................
Catch appropriate KeyError instead of any exception resourceManager.registerNamespace() raises a KeyError exception. Calling methods were catching any exception, treating all as KeyError, which means non-KeyError exceptions were swallowed. Now only KeyErrors are caught and logged as info (instead of warn), and other potential exceptions are not caught at all, i.e., not swallowed anymore. Change-Id: Ifc0fa5ca50e4eb78d62fd3cdc8b09723486bcaa0 Signed-off-by: Vered Volansky <[email protected]> --- M vdsm/storage/blockSD.py M vdsm/storage/sd.py 2 files changed, 6 insertions(+), 6 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/13617 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc0fa5ca50e4eb78d62fd3cdc8b09723486bcaa0 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
