Dan Kenigsberg has posted comments on this change.
Change subject: readlines - remove redundant pathExists check
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/storage/fileSD.py
Line 114: # FileSDMetadata is kept in the file
Line 115: self._metafile = metafile
Line 116: self._sdUUID = getDomUuidFromMetafilePath(metafile)
Line 117: self._oop = oop.getProcessPool(self._sdUUID)
Line 118: self._log = logging.getLogger("FileMetadataRW")
Please ask Vered if this shouldn't be "Storage.FileMetadataRW"
Line 119:
Line 120: def readlines(self):
Line 121: try:
Line 122: return misc.stripNewLines(self._oop.directReadLines(
Line 122: return misc.stripNewLines(self._oop.directReadLines(
Line 123: self._metafile))
Line 124: except (IOError, OSError) as e:
Line 125: if e.errno != errno.ENOENT:
Line 126: self._log.error("Could not retrieve metadata file for
"
I still do not get why we need this spurious log message. it is not the end of
the world - it only adds log noise with no additional info beyond the
traceback. However, we just had a bug about reducing log noise in the storage
subsystem. Please consider dropping this log.
Line 127: "domain in path %s", self._metafile)
Line 128: raise
Line 129: return []
Line 130:
--
To view, visit http://gerrit.ovirt.org/13664
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id73f4bd177465f253eb4f65403b17ff7375e329c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Ohad Basan <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
