Ayal Baron has posted comments on this change.
Change subject: readlines - remove redundant pathExists check
......................................................................
Patch Set 4: No score
(1 inline comment)
Apparently logger name needs fixing
....................................................
File vdsm/storage/fileSD.py
Line 122: return misc.stripNewLines(self._oop.directReadLines(
Line 123: self._metafile))
Line 124: except (IOError, OSError) as e:
Line 125: if e.errno != errno.ENOENT:
Line 126: self._log.error("Could not retrieve metadata file for
"
Because it saves time in debugging issues. It took about 4 people and a lot of
time to figure out that this is the issue without it, so I don't see how this
is a spurious log message.
very few things are 'the end of the world', but not having the metadata file
basically means something went quite awry with your domain. you actually do
want to know this...
Line 127: "domain in path %s", self._metafile)
Line 128: raise
Line 129: return []
Line 130:
--
To view, visit http://gerrit.ovirt.org/13664
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id73f4bd177465f253eb4f65403b17ff7375e329c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Ohad Basan <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
