Zhou Zheng Sheng has posted comments on this change. Change subject: vdsm-tool: add service management utilities ......................................................................
Patch Set 4: Verified Test on Ubuntu, Fedora and RHEL6. In the new patch set, I abandon the ad-hoc implementation of execCmd, and use the "offical" implementation from vdsm.utils. However vdsm.utils.execCmd is actually storage.misc.execCmd, and /usr/share/vdsm is not in PYTHONPATH, so modules of vdsm-tool can not use execCmd. I submit another patch at http://gerrit.ovirt.org/#/c/13917/ to import the execCmd correctly for modules in vdsm-tool, and unify all existing ad-hoc execCmd implementations to use the "official" version. The new patch set of the current patch is rebased on the unifying patch. -- To view, visit http://gerrit.ovirt.org/13701 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd1cbcf5fd00bb1ec73c5970be012e294b3b4c55 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
