Zhou Zheng Sheng has posted comments on this change.

Change subject: vdsm-tool: add service management utilities
......................................................................


Patch Set 4: (1 inline comment)

Thanks Federico! I change the "_" to "-" in the command names in a new patch 
set. It looks better now.

....................................................
File lib/vdsm/tool/service.py
Line 238:                 errors[alt.func_name] = (rc, out, err)
Line 239:     raise RuntimeError("Tried all alternatives but failed:\n%s" % 
errors)
Line 240: 
Line 241: 
Line 242: @expose("service_start")
Done
Line 243: def service_start(srvName):
Line 244:     """
Line 245:     Start a system service
Line 246:     """


--
To view, visit http://gerrit.ovirt.org/13701
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1cbcf5fd00bb1ec73c5970be012e294b3b4c55
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to