Saggi Mizrahi has posted comments on this change. Change subject: Initializing libvirt connectivity in external thread to clientIF ......................................................................
Patch Set 2: I would prefer that you didn't submit this (2 inline comments) .................................................... File vdsm/clientIF.py Line 71 Line 72 Line 73 Line 74 Line 75 self._libvirt = None Line 451: Line 452: def getVDSMVms(self): Line 453: """ Line 454: Return a list of vdsm created VM's. Line 455: """ If it's a public method you need to handle self._libvirt being null if it isn't change it to _getVDSMVms Line 456: domIds = self._libvirt.listDomainsID() Line 457: vms = [] Line 458: for domId in domIds: Line 459: try: -- To view, visit http://gerrit.ovirt.org/14018 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3e849db7685f80995ee56989f0bed405602e550 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
