Federico Simoncelli has posted comments on this change. Change subject: Initializing libvirt connectivity in external thread to clientIF ......................................................................
Patch Set 3: (1 inline comment) Minor comment. .................................................... File vdsm/clientIF.py Line 449: caps.OSName.DEBIAN): Line 450: return True Line 451: return False Line 452: Line 453: def _getVDSMVms(self): Even if you made this method private there's still a self._libvirt dependency (must be defined) that is not explicit. Maybe making this a @classmethod (together with isVDSMVm) that takes a libvirt connection as parameter would prevent any possible future issue with an undefined self._libvirt. Line 454: """ Line 455: Return a list of vdsm created VM's. Line 456: """ Line 457: domIds = self._libvirt.listDomainsID() -- To view, visit http://gerrit.ovirt.org/14018 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3e849db7685f80995ee56989f0bed405602e550 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
