Dan Kenigsberg has posted comments on this change. Change subject: vdsm.spec.in: update raw_version_revision ......................................................................
Patch Set 2: I would prefer that you didn't submit this (1 inline comment) .................................................... Commit Message Line 6: Line 7: vdsm.spec.in: update raw_version_revision Line 8: Line 9: The raw_version_revision from dsaversion.py should be updated with the Line 10: version/release of RPM removing the git stuff. sorry, I do not understand why. raw_version_revision should be just it - the raw version, with no manipulations. And frankly, it should probably have been the complete n-v-r. What is a current example content of raw_version_revision? How do you want it to look? and why? Line 11: Line 12: Change-Id: I8dc1e514ef8fd626018167e1dd13bc58100d5d7b Line 13: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=893193 -- To view, visit http://gerrit.ovirt.org/14011 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8dc1e514ef8fd626018167e1dd13bc58100d5d7b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Ohad Basan <[email protected]> Gerrit-Reviewer: Pavel Zhukov <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
