Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm.spec.in: update raw_version_revision ......................................................................
Patch Set 2: (1 inline comment) .................................................... Commit Message Line 6: Line 7: vdsm.spec.in: update raw_version_revision Line 8: Line 9: The raw_version_revision from dsaversion.py should be updated with the Line 10: version/release of RPM removing the git stuff. Hi Dan, For example: vdsm.log says: vdsm 4.10.2.0.19.gitf9eda0a instead of vdsm.log: vdsm 4.10.2.0.19 as the package release which confuses users. Also, when building the rpm package, software_version and software_revision, are replaced based on Version/Release of RPM spec instead of full autoconf values. In that case, if we want to ship an official release called 4.10.2.15 by changing the spec and the autoconf has a different values (i.e: 4.10.2.0.19) raw_version_revision will use this value and we will have a rpm value and vdsm.log showing another value. Line 11: Line 12: Change-Id: I8dc1e514ef8fd626018167e1dd13bc58100d5d7b Line 13: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=893193 -- To view, visit http://gerrit.ovirt.org/14011 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8dc1e514ef8fd626018167e1dd13bc58100d5d7b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Ohad Basan <[email protected]> Gerrit-Reviewer: Pavel Zhukov <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
