Dan Kenigsberg has posted comments on this change.
Change subject: Update device hooks: Added before and after update device hooks.
......................................................................
Patch Set 6: (1 inline comment)
....................................................
File vdsm/libvirtvm.py
Line 1677:
libvirt.VIR_DOMAIN_AFFECT_LIVE)
Line 1678: self.log.debug("Nic has been updated:\n %s" %
vnicXML)
Line 1679: hooks.after_update_device(vnicXML, self.conf)
Line 1680: except Exception as e:
Line 1681: self.log.debug('Request failed: %s', vnicXML,
exc_info=True)
does this really look nice? the former code had vnicXML.toprettyxml().
Line 1682: hooks.after_update_device_fail(vnicXML, self.conf)
Line 1683: raise SetLinkAndNetworkError(e.message)
Line 1684: yield
Line 1685: except Exception:
--
To view, visit http://gerrit.ovirt.org/13972
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8fe7f5e6d8291cc227a323b324c977bcd5bc8295
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
