Dan Kenigsberg has posted comments on this change.
Change subject: Update device hooks: Added before and after update device hooks.
......................................................................
Patch Set 8: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/libvirtvm.py
Line 1659: try:
Line 1660: try:
Line 1661: vnicXML = hooks.before_update_device(
Line 1662: vnicXML.toprettyxml(encoding='utf-8'), self.conf)
Line 1663: self._dom.updateDeviceFlags(vnicXML,
you now need to update the _deviceXML cache, I believe.
Line 1664:
libvirt.VIR_DOMAIN_AFFECT_LIVE)
Line 1665: self.log.debug("Nic has been updated:\n %s" %
vnicXML)
Line 1666: hooks.after_update_device(vnicXML, self.conf)
Line 1667: except Exception as e:
--
To view, visit http://gerrit.ovirt.org/13972
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8fe7f5e6d8291cc227a323b324c977bcd5bc8295
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
