Dan Kenigsberg has posted comments on this change. Change subject: Added unit test libvirtvmTests.py:TestLibvirtvm.testBuildCmdLine ......................................................................
Patch Set 5: (1 inline comment) .................................................... File tests/libvirtvmTests.py Line 387: # Patch Drive.blockDev to skip the block device checking. Line 388: drive._blockDev = blockDev Line 389: self.assertXML(drive.getXML(), xml % SERIAL) Line 390: Line 391: @testValidation.ValidateRunningAsRoot Few elements of LivirtVm require sudo, and they should be monkey-patched. In this test we want to test conf->domxml conversion, which should be doable by any user. Line 392: def testBuildCmdLine(self): Line 393: #Copy the data that needs to be restored for other tests Line 394: tempConstantVdsmRun = copy.deepcopy(constants.P_VDSM_RUN) Line 395: -- To view, visit http://gerrit.ovirt.org/14111 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74b898a6398a72608d7933009644703aa3f8d831 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maciej Lichon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Maciej Lichon <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
