Bala.FA has posted comments on this change.
Change subject: Added unit test libvirtvmTests.py:TestLibvirtvm.testBuildCmdLine
......................................................................
Patch Set 7: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File tests/libvirtvmTestData.py
Line 61: <feature name="svm" policy="disable"/>
Line 62: <topology cores="1" sockets="1" threads="1"/>
Line 63: </cpu>
Line 64: </domain>
Line 65: """, ]
could you tell me why you need list here?
....................................................
File tests/libvirtvmTests.py
Line 444: re.sub('\n\s*', ' ',
Line 445: expectedOutput.strip(' ')),
Line 446: "XML output match fail" +
Line 447: " at pos " + str(testNum))
Line 448: testNum = testNum + 1
I would prefer
1. parse xml and convert it to dict
2. compare expected dict vs the dict got by conversion
please refer tests/gluster_cli_tests.py who xml vs dict is done.
--
To view, visit http://gerrit.ovirt.org/14111
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I74b898a6398a72608d7933009644703aa3f8d831
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maciej Lichon <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Maciej Lichon <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
