Vinzenz Feenstra has posted comments on this change. Change subject: WIP: Introduce prepareForBackup vdsm verb ......................................................................
Patch Set 1: (1 inline comment) .................................................... File vdsm/storage/hsm.py Line 3072: def prepareBackupDisk(self, sdUUID, spUUID, imgUUID, volUUID): Line 3073: # TODO: Is excl. lock the right thing ? Line 3074: vars.task.getExclusiveLock(STORAGE, sdUUID) Line 3075: snapVol = sdCache.produce( Line 3076: sdUUID=sdUUID).produceVolume( imgUUID=imgUUID, volUUID=volUUID) I know it's more convenient to do it this way, however split into two lines is more readable, imho Line 3077: nbdPath = snapVol.exportAsNbd() Line 3078: return dict(path=nbdPath) Line 3079: Line 3080: @public -- To view, visit http://gerrit.ovirt.org/14403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ccacda2b09810a71f445ed65de6a09336ea3fb1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Deepak C Shetty <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Sharad Mishra <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
