Deepak C Shetty has posted comments on this change.
Change subject: WIP: Introduce prepareForBackup vdsm verb
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/storage/hsm.py
Line 3069: self.log.warn("Problem tearing down volume",
exc_info=True)
Line 3070:
Line 3071: @public
Line 3072: def prepareBackupDisk(self, sdUUID, spUUID, imgUUID, volUUID):
Line 3073: # TODO: Is excl. lock the right thing ?
Per our prev discussion on this matter, looks like we don't need it. Will
remove it in my next patch revision.
Line 3074: vars.task.getExclusiveLock(STORAGE, sdUUID)
Line 3075: snapVol = sdCache.produce(
Line 3076: sdUUID=sdUUID).produceVolume( imgUUID=imgUUID,
volUUID=volUUID)
Line 3077: nbdPath = snapVol.exportAsNbd()
--
To view, visit http://gerrit.ovirt.org/14403
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ccacda2b09810a71f445ed65de6a09336ea3fb1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepa...@linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <a...@us.ibm.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Deepak C Shetty <deepa...@linux.vnet.ibm.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
