Mark Wu has posted comments on this change. Change subject: Only run speed() on nic devices ......................................................................
Patch Set 4: (1 inline comment) .................................................... File vdsm/sampling.py Line 487: class HostStatsThread(StatsThread): Line 488: """ Line 489: A thread that periodically samples host statistics. Line 490: """ Line 491: def __init__(self, cif, log): thanks for your explanation. I agree this will break the usage you mentioned. But actually in the original code, the HostStatsThread.__init__ has one less argument than StatsThread.__init__: ifmacs And in future, if we unify the sampling for guest and host by the StatsThread infrastructure. I suppose the arguments for GuestStatsThread.__init__() should be only cif, log, vmId. So I would like to say probably we need have different handling for HostStatsThread and GuestStatsThread. So I think the case you mentioned doesn't apply here. Line 492: self.startTime = time.time() Line 493: self.nics = netinfo.nics() Line 494: bondings = netinfo.bondings() Line 495: ifids = self.nics + bondings -- To view, visit http://gerrit.ovirt.org/13839 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I721b823a28cc36498119e67061d462b780105e7b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
