Zhou Zheng Sheng has posted comments on this change. Change subject: Supervdsm as external service ......................................................................
Patch Set 8: (2 inline comments) .................................................... File vdsm/supervdsm.py Line 30: _g_singletonSupervdsmInstance_lock = threading.Lock() Line 31: Line 32: Line 33: PIDFILE = os.path.join(constants.P_VDSM_RUN, "supervdsmd.pid") Line 34: AUTHFILE = os.path.join(os.path.dirname(__file__), "supervdsm_auth") Can we make the file readable to vdsmd only? I'm not for generating a different auth key every time, bug prone. P.S. Recently I look at dbus, it's easy to use and provides policy mechanism. It seems that dbus is what we need except there is no Python manager support for dbus. Line 35: TIMESTAMP = os.path.join(constants.P_VDSM_RUN, "svdsm.time") Line 36: ADDRESS = os.path.join(constants.P_VDSM_RUN, "svdsm.sock") Line 37: Line 38: .................................................... File vdsm/supervdsmServer.py Line 392: servThread.join(5) Line 393: finally: Line 394: # Verifing that the socket is related to the current instance of Line 395: # supervdsmServer before removing it. Line 396: if file(PIDFILE, 'r').read().strip() == str(os.getpid()): Thanks for the explanation, agree with you. Line 397: if os.path.exists(address): Line 398: utils.rmFile(address) Line 399: Line 400: except Exception: -- To view, visit http://gerrit.ovirt.org/11051 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I290a584f38129406cd390fdd1d3d1aad9f829a60 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Adam Litke <a...@us.ibm.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: Mei Liu <liu...@linux.vnet.ibm.com> Gerrit-Reviewer: Ohad Basan <oba...@redhat.com> Gerrit-Reviewer: Royce Lv <lvro...@linux.vnet.ibm.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
