Zhou Zheng Sheng has posted comments on this change.
Change subject: Supervdsm as external service
......................................................................
Patch Set 9: (1 inline comment)
....................................................
File configure.ac
Line 189: AC_PATH_PROG([UNPERSIST_PATH], [unpersist], [/usr/sbin/unpersist])
Line 190: AC_PATH_PROG([WGET_PATH], [wget], [/usr/bin/wget])
Line 191: AC_PATH_PROG([YUM_PATH], [yum], [/usr/bin/yum])
Line 192: AC_PATH_PROG([VDSM_TOOL], [vdsm-tool], [/usr/bin/vdsm-tool])
Line 193:
In constant.py.in we can add
EXT_VDSM_TOOL = os.path.join('@prefix@', 'bin', 'vdsm-tool')
or we can use utils.CommandPath.
Line 194: # Keep sorted
Line 195: AC_OUTPUT([
Line 196: Makefile
Line 197: client/Makefile
--
To view, visit http://gerrit.ovirt.org/11051
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I290a584f38129406cd390fdd1d3d1aad9f829a60
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Adam Litke <a...@us.ibm.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com>
Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com>
Gerrit-Reviewer: Mei Liu <liu...@linux.vnet.ibm.com>
Gerrit-Reviewer: Ohad Basan <oba...@redhat.com>
Gerrit-Reviewer: Royce Lv <lvro...@linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
