Zhou Zheng Sheng has posted comments on this change.
Change subject: cpopen: Fix signal handling in sync points
......................................................................
Patch Set 5: Verified
(1 inline comment)
Send signal to parent process and createProcess() retries read.
....................................................
File lib/cpopen/cpopen.c
Line 72: int rv = 0;
Line 73: while (bread < count) {
Line 74: rv = read(fd, cbuff + bread, count - bread);
Line 75: /* EOF */
Line 76: if (rv == 0) {
Is it better that /* EOF */ appears inside " if (rv == 0) {" block?
Line 77: return bread;
Line 78: } else if (rv < 0) {
Line 79: switch (errno) {
Line 80: case EINTR:
--
To view, visit http://gerrit.ovirt.org/15165
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2883091c377c1e4ff9f69b87fc137326b583ab8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
