Eduardo has posted comments on this change.
Change subject: getAllTasksList\Status with spUUID retrieves info only if host
is the SPM
......................................................................
Patch Set 20: Fails
(2 inline comments)
....................................................
File vdsm/storage/sp.py
Line 2103: sdCache.produce(sdUUID).extend(devlist, force)
Line 2104:
Line 2105: def getAllTasksStatuses(self):
Line 2106: if self.lock.acquire(blocking=False):
Line 2107: if self.spmRole == SPM_ACQUIRED:
StoragePool.spmRole is not protected by the SPM lock in force fence.
Line 2108: tasksStatuses =
self.taskMnr.getAllTasksStatuses("spm")
Line 2109: self.lock.release()
Line 2110: return tasksStatuses
Line 2111:
Line 2104:
Line 2105: def getAllTasksStatuses(self):
Line 2106: if self.lock.acquire(blocking=False):
Line 2107: if self.spmRole == SPM_ACQUIRED:
Line 2108: tasksStatuses =
self.taskMnr.getAllTasksStatuses("spm")
A lock can remain locked on exception here.
Line 2109: self.lock.release()
Line 2110: return tasksStatuses
Line 2111:
Line 2112: self.lock.release()
--
To view, visit http://gerrit.ovirt.org/12517
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4cbc11c924f0bd078749fea26d79b39c0dd48094
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Daniel P. Berrange <berra...@redhat.com>
Gerrit-Reviewer: Eduardo <ewars...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com>
Gerrit-Reviewer: Shu Ming <shum...@linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: liron aravot <liron.ara...@gmail.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
