Ayal Baron has posted comments on this change.
Change subject: getAllTasksList\Status with spUUID retrieves info only if host
is the SPM
......................................................................
Patch Set 22: (2 inline comments)
....................................................
File vdsm/storage/hsm.py
Line 2050: # During this race this function can retrieve wrong list of
tasks if
Line 2051: # SPM status changes (HSM tasks or empty task list after
cleaning SPM
Line 2052: # info)
Line 2053: # To reduce the perform SPM request by reading tasks only
under
Line 2054: # StoragePool lock.
s/.*/When spUUID is passed, go to SPM to get pool task list/
Line 2055: if spUUID:
Line 2056: allTasksStatus =
self.getPool(spUUID).getAllTasksStatuses()
Line 2057: else:
Line 2058: allTasksStatus = self.taskMng.getAllTasksStatuses("spm")
Line 2098: # During this race this function can retrieve wrong list of
tasks if
Line 2099: # SPM status changes (HSM tasks or empty task list after
cleaning SPM
Line 2100: # info)
Line 2101: # To reduce the perform SPM request by reading tasks only
under
Line 2102: # StoragePool lock.
same as above.
Line 2103: if spUUID:
Line 2104: allTasksInfo = self.getPool(spUUID).getAllTasksInfo()
Line 2105: else:
Line 2106: allTasksInfo = self.taskMng.getAllTasksInfo("spm")
--
To view, visit http://gerrit.ovirt.org/12517
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4cbc11c924f0bd078749fea26d79b39c0dd48094
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Daniel P. Berrange <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: liron aravot <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
