Dan Kenigsberg has posted comments on this change. Change subject: iproute2 binary wrapper ......................................................................
Patch Set 6: I would prefer that you didn't submit this (2 inline comments) New file is missing from Makefile.am and vdsm.spec. .................................................... File vdsm/ipwrapper.py Line 16: # Line 17: # Refer to the README and COPYING files for full details of the license Line 18: # Line 19: Line 20: from vdsm import utils (former comments ignored) Line 21: import netaddr Line 22: from collections import defaultdict Line 23: Line 24: Line 174: Line 175: def _execCmd(command): Line 176: returnCode, output, error = utils.execCmd(command) Line 177: Line 178: if returnCode: hmm, I had to read the code of ip.c to see that it uses only EXIT_SUCCESS/EXIT_FAILURE, so your test is enough. Line 179: raise IPRoute2Error(error) Line 180: Line 181: return output Line 182: -- To view, visit http://gerrit.ovirt.org/15335 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d315c3294fd7f058cdc840dea329d91a658a304 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller <amul...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Assaf Muller <amul...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
