Antoni Segura Puimedon has posted comments on this change. Change subject: iproute2 binary wrapper ......................................................................
Patch Set 8: (1 inline comment) .................................................... File vdsm/ipwrapper.py Line 162: str += " table %s" % self.table Line 163: Line 164: return str Line 165: Line 166: def __iter__(self): I wouldn't add a base class for this two. The extra abstraction is not justified by the amount of possible code elimination. Line 167: for word in str(self).split(): Line 168: yield word Line 169: Line 170: -- To view, visit http://gerrit.ovirt.org/15335 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d315c3294fd7f058cdc840dea329d91a658a304 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller <amul...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Assaf Muller <amul...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
