Mark Wu has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
......................................................................
Patch Set 8: (2 inline comments)
....................................................
File vdsm/netconf/ifcfg.py
Line 190: self.configWriter.removeBonding(bonding.name)
Line 191: for slave in bonding.slaves:
Line 192: slave.remove()
Line 193: else:
Line 194: self.configWriter.restoreBareBonding(bonding.name)
Sorry, I don't get it very well. Are you talking about the same question in
line 641?
Line 195:
Line 196: def removeNic(self, nic):
Line 197: with self.removeIface(nic) as to_be_removed:
Line 198: if to_be_removed:
Line 637: def restoreBareBonding(self, bonding):
Line 638: cf = netinfo.NET_CONF_PREF + bonding
Line 639: self._updateConfigValue(cf, 'BRIDGE', '', True)
Line 640: self.setBondingMtu(bonding, netinfo.DEFAULT_MTU)
Line 641: self.removeIpConfig(bonding)
Yep, you're right. It's not possible to have both bridge and ipconfig. Here
just remove any previous configurations. Do you think we need separate these
two cases?
Line 642:
Line 643: def removeIpConfig(self, iface):
Line 644: cf = netinfo.NET_CONF_PREF + iface
Line 645: for key in ('IPADDR', 'NETMASK', 'GATEWAY', 'BOOTPROTO'):
--
To view, visit http://gerrit.ovirt.org/14873
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e11fd923a4f5d07d069193278f3eadc94f327ec
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
