Mark Wu has posted comments on this change. Change subject: NetReload: netmodels for delNetwork ......................................................................
Patch Set 9: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/netconf/ifcfg.py Line 178: elif isinstance(iface.master, Bridge): Line 179: self.configWriter.removeBridgeMaster(iface.name) Line 180: yield not multiple_usage Line 181: if multiple_usage: Line 182: self._setNewMtu(iface, _netinfo) should be in next patch Line 183: if not hasattr(iface, 'destroy'): Line 184: ifup(iface.name) Line 185: Line 186: def removeBond(self, bonding): -- To view, visit http://gerrit.ovirt.org/14873 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e11fd923a4f5d07d069193278f3eadc94f327ec Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
