Assaf Muller has posted comments on this change. Change subject: Multiple Gateways: Use SourceRoute when adding/removing networks ......................................................................
Patch Set 1: To all reviewers: This is the final patch in the series. I squashed two previous patches so there's 3 now: ipwrapper, the patch that introduces SourceRoute, and this patch that uses SourceRoute in add/del networks. Additionally, to make my life easier and Mark's harder - I rebased my series of patches against the yet unmerged patch of Mark that refactors delNetwork as part of NetReloaded. Hopefully this hasn't caused too much damage. Known bugs: * In short - The feature doesn't really work yet. * For a DHCP interface, from my minimal testing with a non-VM network, ifdown/up aren't called for some reason and so my rules/routes aren't added. * Static interfaces aren't tested fully, I need to update my engine to master to get the ability to specify gateway on all networks first. * Changing ovirtmgmt from dhcp to static and vice versa causes all sorts of weird stuff. -- To view, visit http://gerrit.ovirt.org/15528 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4415c6ec91ac49c56703d59b99d3a21b328015b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller <amul...@redhat.com> Gerrit-Reviewer: Assaf Muller <amul...@redhat.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
