Dan Kenigsberg has posted comments on this change.
Change subject: Multiple Gateways[2/2]: configNetwork integration
......................................................................
Patch Set 7: I would prefer that you didn't submit this
(3 inline comments)
minor comments only.
....................................................
File vdsm/configNetwork.py
Line 324:
Line 325: if not utils.tobool(force):
Line 326: _validateDelNetwork(network, vlan, bonding, nics, bridged,
_netinfo)
Line 327:
Line 328: netEnt = objectivizeNetwork(bridge=network if bridged else None,
vlan=vlan,
the reason for this code move should be documented in a comment imho.
Line 329: bonding=bonding, nics=nics,
_netinfo=_netinfo,
Line 330: configurator=configurator,
Line 331: implicitBonding=implicitBonding)
Line 332: _removeSourceRoute(netEnt, configurator)
....................................................
File vdsm/netconf/ifcfg.py
Line 183: self.configWriter.setBondingMtu(iface.name, maxMtu)
Line 184: else:
Line 185: self.configWriter.setIfaceMtu(iface.name, maxMtu)
Line 186:
Line 187: def _getFilePath(self, type, device):
When a builtin is over-rided by a local variable, a fairy dies.
Line 188: return os.path.join(netinfo.NET_CONF_DIR, '%s-%s' % (type,
device))
Line 189:
Line 190: def _removeSourceRouteFile(self, type, device):
Line 191: filePath = self._getFilePath(type, device)
....................................................
File vdsm/sourceRoute.sh
Line 1: #!/bin/bash
Line 2:
Line 3: sourceRoute_config() {
Line 4: python /usr/share/vdsm/sourceRoute.pyc "configure" "dhcp"
$new_ip_address $new_subnet_mask $new_routers $interface
tabs? and long lines? in our project!?
Line 5: }
Line 6:
Line 7: sourceRoute_restore() {
Line 8: python /usr/share/vdsm/sourceRoute.pyc "remove" "dhcp"
$interface
--
To view, visit http://gerrit.ovirt.org/15528
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4415c6ec91ac49c56703d59b99d3a21b328015b
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Assaf Muller <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
