Antoni Segura Puimedon has posted comments on this change. Change subject: NetReload: netmodels for delNetwork ......................................................................
Patch Set 14: Fails (1 inline comment) .................................................... File vdsm/netconf/ifcfg.py Line 178: self.configWriter.removeMasterBridge(iface.name) Line 179: to_be_removed = _netinfo.ifaceUsers(iface.name) Line 180: yield not to_be_removed Line 181: Line 182: if to_be_removed or not iface.destroyOnMasterRemoval: I broke this :-( Obvious AttributeError from accessing destroyOnMasterRemoval on Nics. Line 183: ifup(iface.name) Line 184: Line 185: def removeBond(self, bonding): Line 186: with self.removeIface(bonding) as to_be_removed: -- To view, visit http://gerrit.ovirt.org/14873 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e11fd923a4f5d07d069193278f3eadc94f327ec Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Assaf Muller <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
