Antoni Segura Puimedon has posted comments on this change. Change subject: NetReload: netmodels for delNetwork ......................................................................
Patch Set 15: Fails (2 inline comments) .................................................... File vdsm/netconf/ifcfg.py Line 183: slave.remove() Line 184: else: Line 185: self.configWriter.setBondingMtu(bonding.name, Line 186: netinfo.DEFAULT_MTU) Line 187: if to_be_removed or not bonding.destroyOnMasterRemoval: Facepalm. Obviously ifup is if not to be removed. Line 188: ifup(bonding.name) Line 189: Line 190: def removeNic(self, nic): Line 191: to_be_removed = self._ifaceDownAndCleanup(nic) Line 190: def removeNic(self, nic): Line 191: to_be_removed = self._ifaceDownAndCleanup(nic) Line 192: if to_be_removed: Line 193: self.configWriter.removeNic(nic.name) Line 194: ifup(nic.name) Facepalm. Obviously ifup is if not to be removed. Line 195: Line 196: Line 197: class ConfigWriter(object): Line 198: CONFFILE_HEADER = '# automatically generated by vdsm' -- To view, visit http://gerrit.ovirt.org/14873 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e11fd923a4f5d07d069193278f3eadc94f327ec Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Assaf Muller <amul...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
