Lukas Bednar has posted comments on this change. Change subject: Added code coverage plugin ......................................................................
Patch Set 8: Fails built rpms installed: yum install vdsm-4.11.0-30.giteb92231.el6.x86_64.rpm vdsm-cli-4.11.0-30.giteb92231.el6.noarch.rpm vdsm-xmlrpc-4.11.0-30.giteb92231.el6.noarch.rpm vdsm-python-4.11.0-30.giteb92231.el6.x86_64.rpm vdsm-coverage-plugin-4.11.0-30.giteb92231.el6.noarch.rpm vdsm-python-cpopen-4.11.0-30.giteb92231.el6.x86_64.rpm cat /etc/vdsm/coveragerc [run] branch = True data_file = /var/lib/vdsm/coverageresults disabled: codeCoveragePlugin::43::code_coverage::(instrument) Code coverage is disabled. enabled: codeCoveragePlugin::53::code_coverage::(instrument) Starting vdsm code coverage with /etc/vdsm/coveragerc but the results file wasn't generated, because if we use coverage.start(), then we need to also call coverage.stop() in order to generate it. coverage.process_startup() do both automatically. I can go back to coverage.process_startup() function, or create singleton class and call coverage.save() in __del__ . or I would be glad for other your thoughts. -- To view, visit http://gerrit.ovirt.org/15545 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6cb465f7723abad9698aa86bedf2ffc25df55713 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lukas Bednar <lbed...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Lukas Bednar <lbed...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
