Dan Kenigsberg has posted comments on this change.
Change subject: iproute2 binary wrapper
......................................................................
Patch Set 20: Looks good to me, approved
(1 inline comment)
....................................................
File vdsm/ipwrapper.py
Line 37:
Line 38:
Line 39: class Route(object):
Line 40: def __init__(self, network, ipaddr=None, device=None, table=None):
Line 41: if not _isValid(network, IPNetwork):
There's another benefit for the original exception: if provides the faulty text
netaddr.core.AddrFormatError: failed to detect a valid IP address from 'bla'
but let's not waste more time about that.
Line 42: raise ValueError('network is not properly defined')
Line 43:
Line 44: if ipaddr and not _isValid(ipaddr, IPAddress):
Line 45: raise ValueError('ipaddr is not properly defined')
--
To view, visit http://gerrit.ovirt.org/15335
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d315c3294fd7f058cdc840dea329d91a658a304
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Assaf Muller <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
