Dan Kenigsberg has submitted this change and it was merged.
Change subject: iproute2 binary wrapper
......................................................................
iproute2 binary wrapper
Initially to be used by the upcoming multiple gateways
feature. Only the needed commands were implemented.
Patch Set 5:
* Changed Route and Rule parsing to Toni's more
robust method
* Route class: Previously there was a distinction
between a default route and a normal route. I removed
that distinction and the word 'default' in a route
is interpreted as '0.0.0.0/0'
Patch Sets 6-9:
* Empty
Patch Set 10:
* Added ipwrapper.py to spec and make files
PatchSet 11:
* Made changes proposed in earlier reviews.
PatchSet 12:
* Parsing unit tests.
PatchSet 13:
* Added forgotten parsing unit tests.
PatchSet 15:
* Changed name of routeForDevice to reflect that it only returns the single
route for the link network of the device.
PatchSet 16:
* Removed unnecessary output from action performing methods.
PatchSet 17:
* Added python-netaddr to the build requirements.
PatchSet 18:
* Rebased to get the benefits from markin jsonrpc tests as broken.
PatchSet 19:
* Provided more descriptive docstrings for fromText.
Change-Id: I1d315c3294fd7f058cdc840dea329d91a658a304
Signed-off-by: Assaf Muller <[email protected]>
Signed-off-by: Antoni S. Puimedon <[email protected]>
Reviewed-on: http://gerrit.ovirt.org/15335
Reviewed-by: Dan Kenigsberg <[email protected]>
---
M tests/Makefile.am
A tests/ipwrapperTests.py
M vdsm.spec.in
M vdsm/Makefile.am
A vdsm/ipwrapper.py
5 files changed, 305 insertions(+), 0 deletions(-)
Approvals:
Antoni Segura Puimedon: Verified
Dan Kenigsberg: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15335
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1d315c3294fd7f058cdc840dea329d91a658a304
Gerrit-PatchSet: 21
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Assaf Muller <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
