Yeela Kaplan has posted comments on this change. Change subject: Reimplement hsm.getVolumesList(). ......................................................................
Patch Set 2: I would prefer that you didn't submit this (2 inline comments) .................................................... File vdsm/storage/hsm.py Line 3204: Gets a list of all volumes. Line 3205: Line 3206: :param spUUID: The UUID of the storage pool that manages the storage Line 3207: domain you want to query. Line 3208: :type spUUID: Use BLANK_UUID or anything if not connected to SP. AI would remove the "or anything" Line 3209: :param sdUUID: The UUID of the storage domain you want to query. Line 3210: :type sdUUID: UUID Line 3211: :param imgUUID: The UUID of the an image you want to filter the Line 3212: results. Line 3219: if imgUUID == volume.BLANK_UUID: Line 3220: volUUIDs = vols.keys() Line 3221: else: Line 3222: volUUIDs = [k for k, v in vols.itervalues() if imgUUID in v.images] Line 3223: return dict(uuidlist=volUUIDs) v.imgs Line 3224: Line 3225: @public Line 3226: def getImagesList(self, sdUUID, options=None): Line 3227: """ -- To view, visit http://gerrit.ovirt.org/15766 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib810ca24818fa4a77905032694a05c0d86ef75e2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Elad Ben Aharon <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
