Assaf Muller has posted comments on this change. Change subject: Multiple Gateways[1/2]: add sourceRouting module ......................................................................
Patch Set 19: (1 inline comment) .................................................... File vdsm/sourceRoute.py Line 136: rules = self._getRules(network) Line 137: if rules: Line 138: table = self._getTable(rules) Line 139: if table: Line 140: self.rules = rules This was originally so that a SourceRoute object could be passed along to the configurator, with its routes and rules set. Now the routes and rules are passed themselves, so there's no need to save the routes and rules in the SourceRoute class itself. Line 141: self.routes = self._getRoutes(table) Line 142: self.configurator.removeSourceRoute(self.routes, Line 143: self.rules, Line 144: self.device) -- To view, visit http://gerrit.ovirt.org/15207 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0224d896724b9cdc44215e92f0da0be71fd19038 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Assaf Muller <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
