Dan Kenigsberg has posted comments on this change.
Change subject: Multiple Gateways[1/2]: add sourceRouting module
......................................................................
Patch Set 20: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/sourceRoute.py
Line 150: dest='action')
Line 151:
Line 152: configure_parser = subparsers.add_parser('configure')
Line 153: configure_parser.add_argument('bootproto',
Line 154: choices=('static', 'none', 'dhcp'),
I think that I was misunderstood. "BOOTPROTO=static" was frowned upon in
initscripts communities. It means exactly as "none", which should replace it
everywhere in this file, not only in this argument. We certainly do not need
both.
Line 155: help='whether the IP information
was '
Line 156: 'acquired statically or via DHCP')
Line 157: configure_parser.add_argument('ip', help='base IP address of the
network')
Line 158: configure_parser.add_argument('mask', help='Mask of the network
either in '
--
To view, visit http://gerrit.ovirt.org/15207
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0224d896724b9cdc44215e92f0da0be71fd19038
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Assaf Muller <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
