Antoni Segura Puimedon has posted comments on this change.
Change subject: vdscli: make __getLocalVdsName more robust
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File tests/vdsClientTests.py
Line 122:
Line 123: class vdscliTests(TestCaseBase):
Line 124: def test__getLocalVdsName(self):
Line 125: cn = getLocalVdsName('fake',
Line 126: "subject= /O=VDSM Certificate/CN=myhost\n")
This line should be indented to the same column as 'fake' and should be in
single quotes. The same in the lines below.
Line 127: self.assertEquals('myhost', cn)
Line 128: cn = getLocalVdsName('fake',
Line 129: "subject= /CN=myhost/O=VDSM Certificate\n")
--
To view, visit http://gerrit.ovirt.org/16059
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I56bf79904cdf5d0dfcba773f096df1d3ec1670fe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Petr Sebek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
