Giuseppe Vallarelli has posted comments on this change. Change subject: vdscli: make __getLocalVdsName more robust ......................................................................
Patch Set 2: (1 inline comment) .................................................... File lib/vdsm/vdscli.py.in Line 17: # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA Line 18: # Line 19: # Refer to the README and COPYING files for full details of the license Line 20: # Line 21: I know it's not part of the changeset but I think you can fix the import statements here as well. Line 22: import xmlrpclib Line 23: import subprocess Line 24: import os Line 25: from vdsm import SecureXMLRPCServer -- To view, visit http://gerrit.ovirt.org/16059 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56bf79904cdf5d0dfcba773f096df1d3ec1670fe Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com> Gerrit-Reviewer: Petr Šebek <pse...@redhat.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
