Mark Wu has posted comments on this change.

Change subject: Multiple Gateways[1/2]: add sourceRouting module
......................................................................


Patch Set 25: (1 inline comment)

....................................................
File vdsm/sourceRoute.py
Line 214:         configurator = Iproute2()
Line 215:         sourceRoute = DynamicSourceRoute(args.device, configurator)
Line 216: 
Line 217:     if not sourceRoute.isLibvirtInterface():
Line 218:         logging.error("interface %s is not a libvirt interface" %
is it  an error if the interface is not managed by vdsm?
Line 219:                       sourceRoute.device)
Line 220:         return
Line 221: 
Line 222:     if args.action == 'configure':


-- 
To view, visit http://gerrit.ovirt.org/15207
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0224d896724b9cdc44215e92f0da0be71fd19038
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amul...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Assaf Muller <amul...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to