Giuseppe Vallarelli has posted comments on this change. Change subject: Multiple Gateways[1/2]: add sourceRouting module ......................................................................
Patch Set 23: I would prefer that you didn't submit this (2 inline comments) Very minor comments perhaps you're already aware of them. .................................................... File vdsm/netconf/iproute2.py Line 24: from ipwrapper import ruleDel Line 25: Line 26: Line 27: class Iproute2(object): Line 28: def configureSourceRoute(self, sourceRoute, device): self? Same for removeSourceRoute Line 29: for route in sourceRoute.routes: Line 30: routeAdd(route) Line 31: Line 32: for rule in sourceRoute.rules: .................................................... File vdsm/sourceRoute.py Line 23: Line 24: from netconf.ifcfg import Ifcfg, ConfigWriter Line 25: from netconf.iproute2 import Iproute2 Line 26: from vdsm import netinfo Line 27: from ipwrapper import Route Perhaps ipwrapperinfo should stand before netconf or if are 'closer' to this module you can a blank line after netinfo import. Line 28: from ipwrapper import routeShowTable Line 29: from ipwrapper import routeLinkNetForDevice Line 30: from ipwrapper import Rule Line 31: from ipwrapper import ruleList -- To view, visit http://gerrit.ovirt.org/15207 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0224d896724b9cdc44215e92f0da0be71fd19038 Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller <amul...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Assaf Muller <amul...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
