Dan Kenigsberg has submitted this change and it was merged.

Change subject: Fix multiple default gateways reporting
......................................................................


Fix multiple default gateways reporting

Up until now there was just a default gateway per host, defining
default as going towards 0.0.0.0/0. If more than one device
received a default gateway setting, only the latest to be
configured kept its configuration as host default configuration.

Now, thanks to multiple gateways, we have a routing table for each
network, which allows us to have multiple default gateways to
report. The only issue is that /proc/net/route only reports
information for table 254, while we are using several. For this
reason, we change the implementation to use ipwrapper to get the
information from all the tables.

PatchSet 2:
- Fix calling to ipwrapper and added it to lib/vdsm/Makefile.am

PatchSet 3:
- Rebase on top of the fixes of multiple gateways.
- Split Routes fromText into parser and fromText.
- Made source use the new placement and parse method of ipwrapper.

Patch Set 4:
- Rebase the patch.

Change-Id: Iacd6328a938b955a63bbc0d5c0fb9bfcc7de6d44
Signed-off-by: Antoni S. Puimedon <[email protected]>
Reviewed-on: http://gerrit.ovirt.org/15890
Reviewed-by: Dan Kenigsberg <[email protected]>
---
M lib/vdsm/Makefile.am
R lib/vdsm/ipwrapper.py
M lib/vdsm/netinfo.py
M tests/ipwrapperTests.py
M vdsm.spec.in
M vdsm/Makefile.am
M vdsm/netconf/iproute2.py
M vdsm/sourceRoute.py
8 files changed, 53 insertions(+), 54 deletions(-)

Approvals:
  Antoni Segura Puimedon: Verified
  Dan Kenigsberg: Looks good to me, approved


-- 
To view, visit http://gerrit.ovirt.org/15890
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iacd6328a938b955a63bbc0d5c0fb9bfcc7de6d44
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Assaf Muller <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to