Dan Kenigsberg has posted comments on this change. Change subject: Fix multiple default gateways reporting ......................................................................
Patch Set 6: Looks good to me, approved (1 inline comment) .................................................... File lib/vdsm/ipwrapper.py Line 49: self.device = device Line 50: self.table = table Line 51: Line 52: @classmethod Line 53: def parse(cls, text): this shouldn't really be a public method, but /me too tired of this patchset. Line 54: """ Line 55: Returns a dictionary populated with the route attributes found in the Line 56: textual representation. Line 57: """ -- To view, visit http://gerrit.ovirt.org/15890 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iacd6328a938b955a63bbc0d5c0fb9bfcc7de6d44 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Assaf Muller <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
