Yaniv Bronhaim has posted comments on this change.
Change subject: New getChildrenList implementation.
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File vdsm/storage/fileVolume.py
Line 378: gPath = os.path.join(domPath, 'images', '*', '*.meta')
Line 379: metaPaths = oop.getProcessPool(self.sdUUID).glob.glob(gPath)
Line 380: pattern = "%s.*%s" % (volume.PUUID, self.volUUID)
Line 381: matches =
oop.getProcessPool(self.sdUUID).utils.grepCmd(pattern,
Line 382:
metaPaths)
no need for oop, execCmd is already in external process, but you need to make
it synchronized to the next operation. Or wait for the answer, or make the rest
as a callback after event
Line 383: if matches:
Line 384: children = []
Line 385: for line in matches:
Line 386: volMeta = os.path.basename(line.split(':')[0])
--
To view, visit http://gerrit.ovirt.org/15765
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I584cd5d1b03d3965457f12c3d67de95455d1de24
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Elad Ben Aharon <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
